mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 60500: Introduced `--default_container_dns` agent flag.
Date Sat, 15 Jul 2017 01:18:07 GMT


> On July 15, 2017, 2:31 a.m., Jie Yu wrote:
> > src/messages/flags.proto
> > Lines 56 (patched)
> > <https://reviews.apache.org/r/60500/diff/2/?file=1769366#file1769366line56>
> >
> >     Any reason we seperate 'mesos' from 'docker'? Can we use the same?

The reason that we have 'mesos' and 'docker' here is that we want operator to be able to set
DNS info for CNI networks and CNM networks separately. Jie, did you mean we may need to merge
them into one like below so that we do not have 'mesos' and 'docker' anymore?
```
{
  [
    {
      "network": "bridge",
      "dns": {
        "nameservers": [ "8.8.8.8" ]
      }
    },
    {
      "network": "net1",
      "dns": {
        "nameservers": [ "8.8.4.4" ]
      }
    }
  ]
}
```
I think it should be OK. The only potential issue for the above design in my mind is, if there
are 2 networks, 1 CNI and 1 CNM, but they have the same name (say `net1`), and operator may
want to set different DNS for them respectively which can not be achieved with the above design.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60500/#review180566
-----------------------------------------------------------


On July 5, 2017, 3:03 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60500/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 3:03 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-7709
>     https://issues.apache.org/jira/browse/MESOS-7709
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced `--default_container_dns` agent flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 007d0f556375f331148c9ad09be8b301ab31a01c 
>   src/messages/flags.hpp 70ad58c33067a0b058deafdcc4ffc5f554b6ca72 
>   src/messages/flags.proto e87075f19714739b93d9f4aa33ea8686a1bb5613 
>   src/slave/flags.hpp c6803eb54e09a5497755e1e5fef2872193eacba6 
>   src/slave/flags.cpp 398768656b5fa3b7c85474de2b4b008bf7b85cb3 
> 
> 
> Diff: https://reviews.apache.org/r/60500/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message