mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Janco <jjanco....@gmail.com>
Subject Re: Review Request 53479: Perform agent GC asynchronously.
Date Sat, 15 Jul 2017 01:15:10 GMT


> On July 12, 2017, 1:47 a.m., Jiang Yan Xu wrote:
> > src/slave/gc.cpp
> > Lines 179 (patched)
> > <https://reviews.apache.org/r/53479/diff/4/?file=1774291#file1774291line184>
> >
> >     Better to call `onAny` and then `CHECK` that it's always ready in the continuation
so the intention is explicit.
> 
> Jacob Janco wrote:
>     Checked this with a conditional...not sure when CHECK is appropriate.
> 
> Jiang Yan Xu wrote:
>     It's true that the lambda doesn't fail right? The point is that with onAny + CHECK_READY,
it's clearer that we have covered all possible outcomes of the futrue and nothing is overlooked.
>     
>     However looking at it again, the lambda is relatively short and straightfoward so
it's probably fine to drop this and continue to use onReady. onAny + CHECK_READY is fine too
but no need to use `if` for which you need to handle cases that will never happen.

Ah ok, this is a libprocess check on the future. I'll use that to cover all cases.


- Jacob


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53479/#review180261
-----------------------------------------------------------


On July 13, 2017, 9:48 p.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53479/
> -----------------------------------------------------------
> 
> (Updated July 13, 2017, 9:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6549
>     https://issues.apache.org/jira/browse/MESOS-6549
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Previously, rmdir operations were serialized
>   through the garbage collector. Expensive removal
>   events had the potential to delay task launch.
> - MESOS-6549
> 
> 
> Diffs
> -----
> 
>   src/slave/gc.hpp 5ea82456cffa374203371f227b6f0ee00296553e 
>   src/slave/gc.cpp 961f547793984449ea113d9664b12b5033638c58 
> 
> 
> Diff: https://reviews.apache.org/r/53479/diff/6/
> 
> 
> Testing
> -------
> 
> `./bin/mesos-tests.sh --gtest_filter="GarbageCollector*" --gtest_repeat=100 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message