mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.
Date Sat, 15 Jul 2017 00:27:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review180615
-----------------------------------------------------------




src/slave/http.cpp
Line 1312 (original), 1321 (patched)
<https://reviews.apache.org/r/60369/#comment255817>

    Hm.. this seems inconsistent. If we're filtering the allocated resources below based on
whether the client is authorized to view the role, then the "reserved_resources" and "reserved_resources_full"
should also be getting filtered in the same way?
    
    I would suggest either (1) doing the filtering in front of this patch so that this patch
filters consistently, or (2) omit filtering in this patch and introduce it on both in a patch
after this one.


- Benjamin Mahler


On July 14, 2017, 3:37 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> -----------------------------------------------------------
> 
> (Updated July 14, 2017, 3:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
>     https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated". Note that this info might differ
> from the master's view about resource allocations.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 3070b3b06a9d9e75b9d5afb255098e63a1056ec2 
> 
> 
> Diff: https://reviews.apache.org/r/60369/diff/7/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message