mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Review Request 60871: Added double-checked locking for filter.
Date Sat, 15 Jul 2017 00:13:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60871/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

When running in"production" a filter will not be (likely) be set yet
with the current code the threads will experience head-of-line
blocking becaues they'll all queue up on the mutex. Test code will
still queue up but we don't care about the performance in these
situations!

Note that this patch also moves the filter into ProcessManager in the
effort towards eliminating globals.


Diffs
-----

  3rdparty/libprocess/include/process/filter.hpp cafa7be065244fe428dee78c5e02e4513f8c1c35

  3rdparty/libprocess/src/process.cpp 7ce6d2b13baa68906e091a95c0dd58ee1ca2bc7d 


Diff: https://reviews.apache.org/r/60871/diff/1/


Testing
-------


Thanks,

Benjamin Hindman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message