mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 60867: Added method returning allocated resources for executor.
Date Fri, 14 Jul 2017 22:16:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60867/#review180593
-----------------------------------------------------------




src/slave/slave.hpp
Lines 796-797 (original), 798-799 (patched)
<https://reviews.apache.org/r/60867/#comment255796>

    IIUC, this was supposed to represent the resources allocated the executor and is now obviated
by your function, so it should be removed.
    
    We don't have a clear definition of "consumed" here, my understanding is that it meant
the resources "allocated" to the executor.


- Benjamin Mahler


On July 14, 2017, 3:36 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60867/
> -----------------------------------------------------------
> 
> (Updated July 14, 2017, 3:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
>     https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added method returning allocated resources for executor.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 5ede32d00c5dbf18dc0639ec7af5d2a86f86f619 
>   src/slave/slave.cpp 64d24113a1c29a6a9b8401151e6a9fd92511ae40 
> 
> 
> Diff: https://reviews.apache.org/r/60867/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message