mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Quinn Leng <quinn.leng....@gmail.com>
Subject Re: Review Request 60822: Added filtering to /slaves, /slave/containers and /frameworks endpoints.
Date Fri, 14 Jul 2017 00:13:21 GMT


> On July 13, 2017, 9:09 p.m., Quinn Leng wrote:
> > src/master/http.cpp
> > Lines 1561-1562 (original), 1579-1580 (patched)
> > <https://reviews.apache.org/r/60822/diff/3/?file=1776167#file1776167line1593>
> >
> >     Fit one line.

It's too long to fit in one line.


> On July 13, 2017, 9:09 p.m., Quinn Leng wrote:
> > src/slave/http.hpp
> > Line 117 (original), 117 (patched)
> > <https://reviews.apache.org/r/60822/diff/3/?file=1776168#file1776168line117>
> >
> >     const reference

It's better to give flexibility to other's implementation, which might destroy the object.
Thus it's better to keep a copy.


> On July 13, 2017, 9:09 p.m., Quinn Leng wrote:
> > src/slave/http.cpp
> > Line 2112 (original), 2109 (patched)
> > <https://reviews.apache.org/r/60822/diff/3/?file=1776169#file1776169line2117>
> >
> >     const ref

It's better to give flexibility to other's implementation, which might destroy the object.
Thus it's better to keep a copy.


- Quinn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60822/#review180468
-----------------------------------------------------------


On July 13, 2017, 10:59 p.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60822/
> -----------------------------------------------------------
> 
> (Updated July 13, 2017, 10:59 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7630
>     https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added query parameter support for the '/master/slaves',
> '/master/frameworks' and '/slave/containers' endpoints. 
> 
> This allows slaves, frameworks and containers to be queried
> by ID.
> 
> If no ID is specified, all records are returned, consistent
> with current behavior.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2 
>   src/slave/http.hpp ad412d4e2fde13a7afa3563c611ef50b11829cac 
>   src/slave/http.cpp 3070b3b06a9d9e75b9d5afb255098e63a1056ec2 
> 
> 
> Diff: https://reviews.apache.org/r/60822/diff/3/
> 
> 
> Testing
> -------
> 
> Passed 'make check -j48'
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message