mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 60854: Changed the way tests capture agent state transitioning.
Date Thu, 13 Jul 2017 23:41:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60854/#review180490
-----------------------------------------------------------



Patch looks great!

Reviews applied: [60854]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On July 13, 2017, 11 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60854/
> -----------------------------------------------------------
> 
> (Updated July 13, 2017, 11 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-7711
>     https://issues.apache.org/jira/browse/MESOS-7711
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The existing way captures the registrar operation which may not
> occur after MESOS-7711 but regardless of that, capturing the agent
> authorization is equivalent and arguably more straightforward.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 6e6461c2e13c3eb055aa3c2d8ad8e3ac54a1d197 
>   src/tests/reconciliation_tests.cpp 9c36b9a0558ab56ce45fdb93189a1b99f487ba4d 
> 
> 
> Diff: https://reviews.apache.org/r/60854/diff/1/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message