mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Quinn Leng <quinn.leng....@gmail.com>
Subject Re: Review Request 60847: Added test cases for /slaves, /containers, /frameworks endpoints.
Date Thu, 13 Jul 2017 21:33:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60847/#review180479
-----------------------------------------------------------




src/tests/master_tests.cpp
Lines 2545 (patched)
<https://reviews.apache.org/r/60847/#comment255659>

    s/std::string/string/ if possible, here and elsewhere.



src/tests/master_tests.cpp
Lines 2556-2557 (patched)
<https://reviews.apache.org/r/60847/#comment255660>

    Fits on one line



src/tests/master_tests.cpp
Lines 2559-2560 (patched)
<https://reviews.apache.org/r/60847/#comment255661>

    Newline.



src/tests/master_tests.cpp
Lines 2580 (patched)
<https://reviews.apache.org/r/60847/#comment255662>

    s/slave/agent/



src/tests/master_tests.cpp
Lines 2604-2605 (patched)
<https://reviews.apache.org/r/60847/#comment255663>

    One line



src/tests/master_tests.cpp
Lines 6013 (patched)
<https://reviews.apache.org/r/60847/#comment255664>

    s/Ensure/Ensures/



src/tests/master_tests.cpp
Lines 6050 (patched)
<https://reviews.apache.org/r/60847/#comment255667>

    Add a request with no query parameter to verify that both frameworks are returned.
    
    If you remove the previous test, rename this one something like "FrameworkEndpointMultipleFrameworks"



src/tests/master_tests.cpp
Lines 6085-6117 (patched)
<https://reviews.apache.org/r/60847/#comment255666>

    Kill this.



src/tests/master_tests.cpp
Lines 6121-6123 (patched)
<https://reviews.apache.org/r/60847/#comment255665>

    Try to wait until master has marked framework as completed.



src/tests/slave_tests.cpp
Line 2361 (original), 2361 (patched)
<https://reviews.apache.org/r/60847/#comment255668>

    s/executors. And/executors, and/


- Quinn Leng


On July 13, 2017, 9:11 p.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60847/
> -----------------------------------------------------------
> 
> (Updated July 13, 2017, 9:11 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7630
>     https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added query parameter test cases for '/slaves' and '/frameworks' on
> the master, and '/containers' endpoint on the agent.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 6e6461c2e13c3eb055aa3c2d8ad8e3ac54a1d197 
>   src/tests/slave_tests.cpp 035db18db3a64a9e358c1c54cc18a4bdeb85d8bf 
> 
> 
> Diff: https://reviews.apache.org/r/60847/diff/1/
> 
> 
> Testing
> -------
> 
> Passed 'make check -j48'
> Passed 'GTEST_FILTER="MasterTest.FrameworksEndpointQueryFramework" make check -j48'
> Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.FrameworksEndpointQueryFramework"
--gtest_repeat=1000 --gtest_break_on_failure'
> Passed 'GTEST_FILTER="MasterTest.SlavesEndpointQuerySlave" make check -j48'
> Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave"
--gtest_repeat=1000 --gtest_break_on_failure'
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message