mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Quinn Leng <quinn.leng....@gmail.com>
Subject Re: Review Request 60822: Add filtering to /slaves, /slave/containers and /frameworks endpoints.
Date Thu, 13 Jul 2017 21:09:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60822/#review180468
-----------------------------------------------------------




src/master/http.cpp
Lines 1539-1540 (original), 1553-1554 (patched)
<https://reviews.apache.org/r/60822/#comment255644>

    Fit in one line.



src/master/http.cpp
Line 1542 (original), 1556 (patched)
<https://reviews.apache.org/r/60822/#comment255646>

    without a matching ID.



src/master/http.cpp
Lines 1561-1562 (original), 1579-1580 (patched)
<https://reviews.apache.org/r/60822/#comment255645>

    Fit one line.



src/master/http.cpp
Line 1564 (original), 1582 (patched)
<https://reviews.apache.org/r/60822/#comment255647>

    same here



src/master/http.cpp
Line 2466 (original), 2483-2484 (patched)
<https://reviews.apache.org/r/60822/#comment255648>

    Combine these two in one line.



src/master/http.cpp
Lines 2492-2493 (patched)
<https://reviews.apache.org/r/60822/#comment255649>

    If possible:
    
    ```
    return OK(
        jsonify(SlavesWriter(master->slaves, authorizeRole, selectSlaveId)),
        jsonp);
    ```



src/slave/http.hpp
Line 117 (original), 117 (patched)
<https://reviews.apache.org/r/60822/#comment255653>

    const reference



src/slave/http.cpp
Lines 2046-2047 (original), 2046-2047 (patched)
<https://reviews.apache.org/r/60822/#comment255652>

    Try doing:
    ```
    return __containers(authorizeContainer, None());
    ```



src/slave/http.cpp
Line 2083 (original), 2080 (patched)
<https://reviews.apache.org/r/60822/#comment255656>

    too many spaces



src/slave/http.cpp
Line 2112 (original), 2109 (patched)
<https://reviews.apache.org/r/60822/#comment255654>

    const ref


- Quinn Leng


On July 13, 2017, 8:30 p.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60822/
> -----------------------------------------------------------
> 
> (Updated July 13, 2017, 8:30 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7630
>     https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added query parameter support for the '/master/slaves',
> '/master/frameworks' and '/slave/containers' endpoints. 
> 
> This allows slaves, frameworks and containers to be queried
> by ID.
> 
> If no ID is specified, all records are returned, consistent
> with current behavior.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2 
>   src/slave/http.hpp ad412d4e2fde13a7afa3563c611ef50b11829cac 
>   src/slave/http.cpp 3070b3b06a9d9e75b9d5afb255098e63a1056ec2 
> 
> 
> Diff: https://reviews.apache.org/r/60822/diff/3/
> 
> 
> Testing
> -------
> 
> Passed 'make check -j48'
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message