mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 60598: Replaced `abort()` with `_exit()` in `ChildHook::SUPERVISOR`.
Date Thu, 13 Jul 2017 20:28:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60598/#review180464
-----------------------------------------------------------



We try to include the commit message when marking as submitted, can you do that Alexander?
E.g. https://reviews.apache.org/r/60423/

Also, AFAICT the commit description here isn't accurate, it says

> was called in `SUPERVISOR` hook when child process exited with an error code

However, looking at the code, this case is actually that the opposite. We were aborting when
`!WIFEXITED` which means the child didn't exit normally with `exit` or `_exit`, this case
is the child process terminated because it received a signal that was not handled.

- Benjamin Mahler


On July 11, 2017, 9:24 a.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60598/
> -----------------------------------------------------------
> 
> (Updated July 11, 2017, 9:24 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin Bannier, Benjamin
Mahler, and James Peach.
> 
> 
> Bugs: MESOS-7775
>     https://issues.apache.org/jira/browse/MESOS-7775
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, `abort()` was called in `SUPERVISOR` hook when child
> process exited with an error code, or `waitpid()` failed, or parent
> process exited. All these cases shouldn't lead to abnormal program
> termination with coredumps.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/subprocess.cpp b65484ce36c99b7bb4b5585a3b0183d19fc88129 
> 
> 
> Diff: https://reviews.apache.org/r/60598/diff/4/
> 
> 
> Testing
> -------
> 
> make check (mac os x, fedora 25)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message