mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Quinn Leng <quinn.leng....@gmail.com>
Subject Re: Review Request 60716: Cleaned up authentication acceptor to have one class.
Date Thu, 13 Jul 2017 20:24:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60716/#review180466
-----------------------------------------------------------




src/common/http.hpp
Lines 225-226 (original), 204-205 (patched)
<https://reviews.apache.org/r/60716/#comment255643>

    New line between these two lines.


- Quinn Leng


On July 13, 2017, 8:18 p.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60716/
> -----------------------------------------------------------
> 
> (Updated July 13, 2017, 8:18 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7630
>     https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace different authorization-related Acceptor classes with one
> AuthorizationAcceptor class.
> 
> Removed the ObjectAcceptor parent class, since no inheritance features
> are provided by it.
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e 
>   src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309 
>   src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2 
> 
> 
> Diff: https://reviews.apache.org/r/60716/diff/4/
> 
> 
> Testing
> -------
> 
> Passed "make check -j48"
> Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48'
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message