mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 60492: Added network/ports isolator skeleton.
Date Thu, 13 Jul 2017 09:03:50 GMT


> On July 13, 2017, 4:58 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Lines 412 (patched)
> > <https://reviews.apache.org/r/60492/diff/5/?file=1775856#file1775856line412>
> >
> >     Usually we do such change after the isolator is fully implemented since we do
not want user to enable an isolator which has not been implemented yet.

So I would suggest to put this change to a separate patch and move it to the end of the review
chain.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60492/#review180409
-----------------------------------------------------------


On June 28, 2017, 3:44 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60492/
> -----------------------------------------------------------
> 
> (Updated June 28, 2017, 3:44 p.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the skeleton of the `network/ports` isolator and wired it up
> to the autotools build and the Mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am b5cd45d24f38d5bae590978f49a3ca5440a2a0ab 
>   src/slave/containerizer/mesos/containerizer.cpp 9376d14d66f5dc7e91c7c0e9da253f5eb9347539

>   src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60492/diff/5/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message