mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 60520: Removed posix/subprocess.hpp dependencies.
Date Thu, 13 Jul 2017 00:11:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60520/#review180380
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On June 28, 2017, 10:49 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60520/
> -----------------------------------------------------------
> 
> (Updated June 28, 2017, 10:49 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Greg Mann.
> 
> 
> Bugs: MESOS-7778
>     https://issues.apache.org/jira/browse/MESOS-7778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix a number of places where we were depending on symbols made
> visible by <process/posix/subprocess.hpp>. In most cases, this is
> just tweaking the includes, but in the Checker we just duplicate
> the trivial fork(2) helper since that is easer than trying to
> export it as a libprocess API.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker_process.cpp 66f5452bb5f9c7f45819c221be7b098e5999b7a7 
>   src/slave/containerizer/mesos/isolators/volume/image.cpp c89af3e0a16f769c45f2846d1e76baedb8248d4d

>   src/uri/fetchers/docker.cpp 7f3e4e73d1dc5d15f875e2890acbe5369fb59d78 
> 
> 
> Diff: https://reviews.apache.org/r/60520/diff/5/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26).
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message