mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 60712: Added filtering support for '/slave/containers' endpoint.
Date Wed, 12 Jul 2017 22:45:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60712/#review180368
-----------------------------------------------------------



Bad patch!

Reviews applied: [60712, 60581, 60580, 60716, 60279]

Failed command: python support/apply-reviews.py -n -r 60581

Error:
error: patch failed: src/master/http.cpp:2326
error: src/master/http.cpp: patch does not apply

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/144/console

- Mesos Reviewbot Windows


On July 7, 2017, 11:47 p.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60712/
> -----------------------------------------------------------
> 
> (Updated July 7, 2017, 11:47 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7630
>     https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added filtering support for '/slave/containers' endpoint.
> 
> Add query parameter support for '/slave/containers' endpoint.
> To get the information about a specific container, you can specify
> the container_id. The request would look like
> '/slave/containers?container_id=[container id]'.
> 
> When no container id is specified, it will return the information
> about all containers.
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp b7e4a8adcbcaa3a962af795c67694a35161b6c1a 
>   src/common/http.cpp fdb591eccf273260902f3f695cf431f72ee3d817 
>   src/slave/http.hpp ad412d4e2fde13a7afa3563c611ef50b11829cac 
>   src/slave/http.cpp 700871e1502a65b0bb1fc31219e09219dbdb5340 
>   src/tests/slave_tests.cpp 8a69cc2ede0b2f17a31986e9142aa2081691eb5e 
> 
> 
> Diff: https://reviews.apache.org/r/60712/diff/2/
> 
> 
> Testing
> -------
> 
> Passed 'make check -j48'
> Passed 'GLOG_v=1 ./bin/mesos-test.sh --gtest_filter=SlaveTest.ContainersEndpoint --gtest_repeat=1000
--gtest_break_on_failure'
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message