mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 60716: Cleaned up authentication acceptor to have one class.
Date Wed, 12 Jul 2017 17:50:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60716/#review180322
-----------------------------------------------------------




src/common/http.hpp
Lines 175-177 (original), 173-185 (patched)
<https://reviews.apache.org/r/60716/#comment255432>

    Is there a reason this implementation is placed in the header?



src/common/http.hpp
Lines 176-178 (patched)
<https://reviews.apache.org/r/60716/#comment255433>

    This can fit on two lines.


- Greg Mann


On July 12, 2017, 1:17 a.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60716/
> -----------------------------------------------------------
> 
> (Updated July 12, 2017, 1:17 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7630
>     https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up authentication acceptor to have one class.
> 
> Replace different Authorization related Acceptor classes with one
> AuthorizationAcceptor class.
> 
> Single static create function for AuthorizationAcceptor. 
> Templated 'accept' function to take different number and types of
> parameters.
> 
> Removed ObjectAcceptor parent class, since no inheritance feature
> provided by it.
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e 
>   src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309 
>   src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2 
> 
> 
> Diff: https://reviews.apache.org/r/60716/diff/3/
> 
> 
> Testing
> -------
> 
> Passed "make check -j48"
> Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48'
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message