mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 60494: Expose LinuxLauncher cgroups helper.
Date Wed, 12 Jul 2017 14:55:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60494/#review180291
-----------------------------------------------------------




src/slave/containerizer/mesos/linux_launcher.cpp
Line 112 (original), 112-115 (patched)
<https://reviews.apache.org/r/60494/#comment255373>

    Do we really need this wrapper? I see previously `LinuxLauncherProcess::cgroup()` was
only called by `LinuxLauncherProcess::destroy()`, so what about just changing `LinuxLauncherProcess::destroy()`
to call `LinuxLauncher::cgroup()` directly?


- Qian Zhang


On July 11, 2017, 7:11 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60494/
> -----------------------------------------------------------
> 
> (Updated July 11, 2017, 7:11 p.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Expose the LinuxLauncher cgroups helper to generate the cgroups
> path from a container ID. This is needed by the `network/ports`
> isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/linux_launcher.hpp e1525231e0a374bc044e929e82b8d051732e97cb

>   src/slave/containerizer/mesos/linux_launcher.cpp 1cea04edac8e0c4aea8c1c7d946b5065f3eac931

> 
> 
> Diff: https://reviews.apache.org/r/60494/diff/3/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message