mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 60788: Windows: Fixed long path support in `reparsepoint.hpp`.
Date Wed, 12 Jul 2017 05:01:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60788/#review180277
-----------------------------------------------------------



Patch looks great!

Reviews applied: [60788]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On July 12, 2017, 1:44 a.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60788/
> -----------------------------------------------------------
> 
> (Updated July 12, 2017, 1:44 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixes an error on my part where I accidentally didn't use the
> `longpath` helper, but just `wide_stringify` in two instances.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 066c192586f0a9bf74127342e827f38c9de1b4ca

> 
> 
> Diff: https://reviews.apache.org/r/60788/diff/1/
> 
> 
> Testing
> -------
> 
> mesos-tests
> 
> Fixes a bug I'd rather not talk about.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message