mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 60791: Add fetcher cache space usage metrics.
Date Wed, 12 Jul 2017 02:48:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60791/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-7782
    https://issues.apache.org/jira/browse/MESOS-7782


Repository: mesos


Description
-------

Add fetcher metrics to track the (constant) size of the cache size
and the (varying) amount of cache space use. The cache size is
published as `containerizer/fetcher/cache_size_total` and the used
space is `containerizer/fetcher/cache_size_used`. Both of these
metrics are in MB to be consistent with other disk space metrics.


Diffs
-----

  docs/monitoring.md 38b8093ef683b5de65cbfa5330a6bbd1c9e10f12 
  src/slave/containerizer/fetcher.cpp 6a664e0657a19d27afac98fd5298d6a18aabe43f 
  src/slave/containerizer/fetcher_process.hpp 0a342303574927ebfb8c60e6ce2ebe67bd8a12a3 
  src/tests/fetcher_cache_tests.cpp 6e4736ea42430017ca6eff9134c1136179a4b26f 


Diff: https://reviews.apache.org/r/60791/diff/1/


Testing
-------

make check (Fedora 26).


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message