mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 60784: Fixed a bug in operator== for DiskInfo::Source.
Date Tue, 11 Jul 2017 22:29:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60784/
-----------------------------------------------------------

Review request for mesos and Greg Mann.


Repository: mesos


Description
-------

The previous implementation was incorrect for the case when either
`right.path` or `right.mount` is set but the corresponding field in
`left` is unset.


Diffs
-----

  src/common/resources.cpp 3f4fff4f1dbe9c8acc55e3077212fe329e53e4d9 
  src/v1/resources.cpp 55d493e89114acc94b1524f3f94a47ccea20469a 


Diff: https://reviews.apache.org/r/60784/diff/1/


Testing
-------

`make check`

I tried to write a unit test for this specific problem but wasn't able to repro :-\ Current
coding seems wrong / inconsistent in any case, though.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message