mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 60720: Fixed initialization of `__address__` in the abscense of `--ip` flag.
Date Tue, 11 Jul 2017 21:57:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60720/#review180249
-----------------------------------------------------------



Will addressing the changes suggested by Yan in a separate patch, so closing this out.

- Avinash sridharan


On July 11, 2017, 9:56 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60720/
> -----------------------------------------------------------
> 
> (Updated July 11, 2017, 9:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7769
>     https://issues.apache.org/jira/browse/MESOS-7769
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When we introduced the `__address6__ optional IPv6 storage into
> `libprocess` we also introduced a regression because of which the `port`
> doesn't get initialized to whatever is specified in the `--port` flag
> until the `--ip` flag is specified.
> 
> This change fixes the initialization of the `__address__` in the
> absence of the `--ip` flag.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 264298c16199ded4ccbf948f6893f4209c23aed0 
> 
> 
> Diff: https://reviews.apache.org/r/60720/diff/1/
> 
> 
> Testing
> -------
> 
> sudo ./build/bin/mesos-agent.sh  --port=5059 --master=10.0.2.15:5050 --work_dir=/tmp/mesos
> tcp        0      0 0.0.0.0:5059            0.0.0.0:*               LISTEN
> 
> sudo ./build/bin/mesos-agent.sh  --ip=10.0.2.15 --port=5059 --master=10.0.2.15:5050 --work_dir=/tmp/mesos
> tcp        0      0 10.0.2.15:5059          0.0.0.0:*               LISTEN
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message