mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 60580: Added filtering to the '/frameworks' endpoint.
Date Tue, 11 Jul 2017 21:42:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60580/#review180248
-----------------------------------------------------------




src/tests/master_tests.cpp
Lines 5669-5670 (patched)
<https://reviews.apache.org/r/60580/#comment255327>

    The intention is for frameworks to subscribe initially without a framework ID, and the
master then assigns them a framework ID. Unfortunately, we currently allow frameworks to register
with unrecognized framework IDs because the master doesn't persist existing framework infos.
    
    So it would be better here to follow the intended pattern and subscribe without a framework
ID in the FrameworkInfo. Then, you can extract the framework ID from the `registered` call
and add it to your `expected` JSON blob.


- Greg Mann


On July 7, 2017, 11:20 p.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60580/
> -----------------------------------------------------------
> 
> (Updated July 7, 2017, 11:20 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7630
>     https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added filtering to the '/frameworks' endpoint.
> 
> Add query parameter support for '/frameworks' endpoint.
> To query the information about a specific framework, we
> can use 'framework_id' to specify the framework, thus it
> looks like'/frameworks?framework_id=[framework id]'
> 
> To maintain consistency, the structure for response is
> reserved, thus the response still contains field 'frameworks'
> and 'completed_frameworks' etc..
> 
> Since code for '/state' endpoint and '/frameworks' are coupled
> (they share 'FullFrameworkWriter' class), thus the code for '/state'
> endpoint is also updated.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 175a44ce7fb5be509453c25eaa9ec29f35adba3a 
>   src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f 
> 
> 
> Diff: https://reviews.apache.org/r/60580/diff/3/
> 
> 
> Testing
> -------
> 
> Passed 'make check -j48'
> Passed 'GTEST_FILTER="MasterTest.FrameworksEndpointQueryFramework" make check -j48'
> Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.FrameworksEndpointQueryFramework"
--gtest_repeat=1000 --gtest_break_on_failure'
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message