mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 60729: Fixed persistent volume and host volume conflict issue.
Date Tue, 11 Jul 2017 18:58:35 GMT


> On July 11, 2017, 9:19 a.m., James DeFelice wrote:
> > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
> > Line 730 (original), 730 (patched)
> > <https://reviews.apache.org/r/60729/diff/2/?file=1772956#file1772956line730>
> >
> >     perhaps we should expand this comment to cover the additional use case that
we're actually enabling here: that there may be multiple references to the same mount target
due to a combination of host-volume mounts and persistent vols

Good point. Updated the comments.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60729/#review180201
-----------------------------------------------------------


On July 10, 2017, 11 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60729/
> -----------------------------------------------------------
> 
> (Updated July 10, 2017, 11 a.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7770
>     https://issues.apache.org/jira/browse/MESOS-7770
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is the fix for MESOS-7770. Basically, if a persistent volume
> and a host volume are both specified and the source path of the
> host volume is the same as the container path of the persistent
> volume, then the persistent volume will be skipped and is not
> mounted correctly. We should precisely check the mount table
> to determine whether the persistent volume is mounted or not.
> If not mounted, make sure we do mount the persistent volume.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 69804eec61467ae0fd95dfdf53a08875e27a0bca

> 
> 
> Diff: https://reviews.apache.org/r/60729/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message