mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 60580: Added filtering to the '/frameworks' endpoint.
Date Tue, 11 Jul 2017 18:47:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60580/#review180220
-----------------------------------------------------------



I still need to look at the test, but find below comments on the functional changes.

Also, it looks like this patch currently has conflicts - could you rebase?


src/master/http.cpp
Lines 1353 (patched)
<https://reviews.apache.org/r/60580/#comment255273>

    This last empty string can be omitted.



src/master/http.cpp
Lines 1415-1417 (original), 1416 (patched)
<https://reviews.apache.org/r/60580/#comment255278>

    Let's retain the pattern of explicitly capturing the acceptors by reference. This allows
us to avoid copying `Owned` objects.



src/master/http.cpp
Lines 1437-1439 (original), 1437 (patched)
<https://reviews.apache.org/r/60580/#comment255279>

    Ditto regarding by-reference capture.



src/master/http.cpp
Lines 2821-2822 (original), 2804 (patched)
<https://reviews.apache.org/r/60580/#comment255285>

    Ditto regarding by-reference capture.



src/master/http.cpp
Lines 2842-2843 (original), 2825 (patched)
<https://reviews.apache.org/r/60580/#comment255286>

    Ditto regarding by-reference capture.



src/tests/master_tests.cpp
Lines 5660 (patched)
<https://reviews.apache.org/r/60580/#comment255293>

    s/query parameter/a query parameter/



src/tests/master_tests.cpp
Lines 5661 (patched)
<https://reviews.apache.org/r/60580/#comment255295>

    s/correct number and content of framework/the correct framework/


- Greg Mann


On July 7, 2017, 11:20 p.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60580/
> -----------------------------------------------------------
> 
> (Updated July 7, 2017, 11:20 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7630
>     https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added filtering to the '/frameworks' endpoint.
> 
> Add query parameter support for '/frameworks' endpoint.
> To query the information about a specific framework, we
> can use 'framework_id' to specify the framework, thus it
> looks like'/frameworks?framework_id=[framework id]'
> 
> To maintain consistency, the structure for response is
> reserved, thus the response still contains field 'frameworks'
> and 'completed_frameworks' etc..
> 
> Since code for '/state' endpoint and '/frameworks' are coupled
> (they share 'FullFrameworkWriter' class), thus the code for '/state'
> endpoint is also updated.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 175a44ce7fb5be509453c25eaa9ec29f35adba3a 
>   src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f 
> 
> 
> Diff: https://reviews.apache.org/r/60580/diff/3/
> 
> 
> Testing
> -------
> 
> Passed 'make check -j48'
> Passed 'GTEST_FILTER="MasterTest.FrameworksEndpointQueryFramework" make check -j48'
> Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.FrameworksEndpointQueryFramework"
--gtest_repeat=1000 --gtest_break_on_failure'
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message