-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60397/#review180223
-----------------------------------------------------------
src/linux/perf.cpp
Line 238 (original), 243-249 (patched)
<https://reviews.apache.org/r/60397/#comment255284>
This is executing `perf --version` twice, and if someone were to call `perf::version()`
(or other `perf::` functions) without calling `perf::supported()` then the core dump issue
would surface again?
Could we instead just update `perf::version` and all other perf commands we run to disable
core dumps? They all should be going through the `Perf` class in the implementation.
(I don't think we mandated that any `perf::` function must only be called after `perf::supported()`
has been called and returned true)
- Benjamin Mahler
On July 11, 2017, 9:25 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60397/
> -----------------------------------------------------------
>
> (Updated July 11, 2017, 9:25 a.m.)
>
>
> Review request for mesos, Alexander Rojas, Benjamin Bannier, James Peach, and Neil Conway.
>
>
> Bugs: MESOS-7160
> https://issues.apache.org/jira/browse/MESOS-7160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For autotools build, the docker-build script performs a 'distcheck'
> build. This type of build warns if any unexpected files are left in
> the build directory after an uninstall, mainly to detect broken
> uninstall Makefile rules. The return status of the build container is
> the result of the distcheck.
> This fixes an issue where in some dockerized configurations
> invocations of 'perf' segfaulted (producing a core file as a
> side-effect), where the failure case was already anticipated and
> handled by the caller.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp b301e25d5cac6488c57e4f983e4867c72368a040
> src/tests/containerizer/perf_tests.cpp d8aab08eb131f974821fb85662cbc6cc685d2f3e
>
>
> Diff: https://reviews.apache.org/r/60397/diff/4/
>
>
> Testing
> -------
>
> 1. make check (mac os x 10.12, fedora 25)
> 2. internal CI
>
> Needs to be confirmed by Apache CI, e.g., reviewbot.
>
>
> Thanks,
>
> Andrei Budnik
>
>
|