mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 60704: Handled EINTR for `waitpid()` in ChildHook::SUPERVISOR from subprocess.
Date Tue, 11 Jul 2017 17:41:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60704/#review180221
-----------------------------------------------------------


Ship it!





3rdparty/libprocess/src/subprocess.cpp
Lines 173-174 (original), 173-177 (patched)
<https://reviews.apache.org/r/60704/#comment255280>

    Maybe a bit simpler as:
    
    ```
            if (errno != EINTR) {
              abort();
            }
    ```


- Benjamin Mahler


On July 11, 2017, 9:24 a.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60704/
> -----------------------------------------------------------
> 
> (Updated July 11, 2017, 9:24 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin Bannier, and
James Peach.
> 
> 
> Bugs: MESOS-7160
>     https://issues.apache.org/jira/browse/MESOS-7160
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Handled EINTR for `waitpid()` in ChildHook::SUPERVISOR from subprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/subprocess.cpp 0f1532b294d6d6b1e017468cfde47362f3faa84d 
> 
> 
> Diff: https://reviews.apache.org/r/60704/diff/1/
> 
> 
> Testing
> -------
> 
> make check (mac os x, fedora 25)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message