mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 60769: Added evolve functions for resource provider Event/Call.
Date Tue, 11 Jul 2017 17:21:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60769/#review180215
-----------------------------------------------------------


Fix it, then Ship it!





src/internal/evolve.hpp
Lines 114-115 (patched)
<https://reviews.apache.org/r/60769/#comment255267>

    I'd suggest recorder these two methods in this file and put them right above:
    ```
    v1::scheduler::Call evolve(const scheduler::Call& call);
    ```



src/internal/evolve.cpp
Lines 240 (patched)
<https://reviews.apache.org/r/60769/#comment255269>

    Ditto on ordering.


- Jie Yu


On July 11, 2017, 12:46 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60769/
> -----------------------------------------------------------
> 
> (Updated July 11, 2017, 12:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7780
>     https://issues.apache.org/jira/browse/MESOS-7780
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added evolve functions for resource provider Event/Call.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 9db5fe6155243576f186a8b974e81068505b9fcb 
>   src/internal/evolve.cpp 93196f301e820b99572ee008b98a124ddafe9697 
> 
> 
> Diff: https://reviews.apache.org/r/60769/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message