mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 60768: Added resource provider ID to calls.
Date Tue, 11 Jul 2017 17:19:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60768/#review180214
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/resource_provider/resource_provider.proto
Line 86 (original), 86 (patched)
<https://reviews.apache.org/r/60768/#comment255264>

    I'd suggest we expand this comments to be more descriptive:
    ```
    // Identifies who generated this call. The ResourceProviderManager
    // assigns a resource provider id when a new resource provider
    // subscribes for the first time. Once assigned, the resource provider
    // must set the 'resource_provider_id' here and within its
    // ResourceProviderInfo (in any further 'Subscribe' calls). This allows
    // the ResourceProviderManager to identify a resource provider correctly 
    // across disconnections, failovers, etc.
    ```



include/mesos/v1/resource_provider/resource_provider.proto
Line 86 (original), 86 (patched)
<https://reviews.apache.org/r/60768/#comment255265>

    Ditto here.


- Jie Yu


On July 11, 2017, 12:44 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60768/
> -----------------------------------------------------------
> 
> (Updated July 11, 2017, 12:44 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7780
>     https://issues.apache.org/jira/browse/MESOS-7780
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The resource provider manager needs to know from which resource provider
> calls originated.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto 11d01df114eafb729514dab64596c5f1ecf09f26

>   include/mesos/v1/resource_provider/resource_provider.proto 97a85ce34eeecf86d14c097712867cd24624a6ec

> 
> 
> Diff: https://reviews.apache.org/r/60768/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message