mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James DeFelice <james.defel...@gmail.com>
Subject Re: Review Request 60750: Added unit tests for persistent volume and host volume conflict issue.
Date Tue, 11 Jul 2017 16:15:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60750/#review180199
-----------------------------------------------------------




src/tests/containerizer/linux_filesystem_isolator_tests.cpp
Lines 568 (patched)
<https://reviews.apache.org/r/60750/#comment255241>

    shouldn't this be /volume/file to test that the mounts are all done in the proper order?
in other words, writing to /volume/file in the container's mountns should result in a write
to volume/file (relative to the container's sandbox).
    
    this is typically why containers use this workaround approach, because there's an absolute
path in the container's mountns that some process wants to read-from/write-to


- James DeFelice


On July 10, 2017, 6 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60750/
> -----------------------------------------------------------
> 
> (Updated July 10, 2017, 6 p.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7770
>     https://issues.apache.org/jira/browse/MESOS-7770
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit tests for persistent volume and host volume conflict issue.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 803758c1437b21df9f25ad7e994298e89de44cbe

> 
> 
> Diff: https://reviews.apache.org/r/60750/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> Checked this unit test failed before our fix and passed now.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message