mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 60279: Add constructor for ObjectApprover::Object.
Date Tue, 11 Jul 2017 15:38:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60279/#review180195
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On July 7, 2017, 8:01 p.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60279/
> -----------------------------------------------------------
> 
> (Updated July 7, 2017, 8:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7630
>     https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add constructor for ObjectApprover::Object.
> 
> Updated all places where ObjectApprover::Objects
> are constructed to use the constructor.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.hpp 95cbcf3f9a962a896c9c23e961f02eb16dff36f8 
>   src/common/http.cpp fdb591eccf273260902f3f695cf431f72ee3d817 
>   src/master/http.cpp 175a44ce7fb5be509453c25eaa9ec29f35adba3a 
>   src/slave/http.cpp 700871e1502a65b0bb1fc31219e09219dbdb5340 
> 
> 
> Diff: https://reviews.apache.org/r/60279/diff/4/
> 
> 
> Testing
> -------
> 
> Passed "make check -j48"
> Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48'
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message