mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60337: Windows: Made `os::user()` use Unicode.
Date Tue, 11 Jul 2017 00:17:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60337/#review180125
-----------------------------------------------------------


Ship it!





3rdparty/stout/include/stout/os/windows/su.hpp
Line 91 (original), 91 (patched)
<https://reviews.apache.org/r/60337/#comment255149>

    This didn't apply (cleanly) because the linter complained about this line's length.  I'll
tweak it.


- Joseph Wu


On June 21, 2017, 3:16 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60337/
> -----------------------------------------------------------
> 
> (Updated June 21, 2017, 3:16 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu,
Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-6817
>     https://issues.apache.org/jira/browse/MESOS-6817
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Made `os::user()` use Unicode.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/su.hpp 573fdefdf38ae8560059c6a0c512ef561ca617b2

> 
> 
> Diff: https://reviews.apache.org/r/60337/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message