mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60336: Windows: Made environment abstractions use Unicode.
Date Tue, 11 Jul 2017 00:17:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60336/#review180124
-----------------------------------------------------------


Ship it!





3rdparty/stout/include/stout/os/windows/getenv.hpp
Line 41 (original), 43 (patched)
<https://reviews.apache.org/r/60336/#comment255145>

    Hum.  The rest of this chain uses `.reserve` when hitting this pattern.


- Joseph Wu


On June 21, 2017, 3:16 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60336/
> -----------------------------------------------------------
> 
> (Updated June 21, 2017, 3:16 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu,
Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-6817
>     https://issues.apache.org/jira/browse/MESOS-6817
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Made environment abstractions use Unicode.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/environment.hpp 96f0eb4f56a73f4058eeaf68502e441bd00147a8

>   3rdparty/stout/include/stout/os/windows/getenv.hpp 2200f8527da0c8d5a5ffee287eb86e4d0cb58b8b

>   3rdparty/stout/include/stout/windows/os.hpp f1722d5e18af97d89c6ca7aaf002fd58cb0d21ae

> 
> 
> Diff: https://reviews.apache.org/r/60336/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message