mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60328: Windows: Added `create_process()` wrapper to `shell.hpp`.
Date Tue, 11 Jul 2017 00:16:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60328/#review180093
-----------------------------------------------------------


Ship it!




I can make the tweak below and the cascading changes in subsequent reviews.


3rdparty/stout/include/stout/os/windows/shell.hpp
Lines 270-283 (patched)
<https://reviews.apache.org/r/60328/#comment255121>

    Since all three FDs must be supplied together, we should change the argument from 3 arguments
to 1:
    
    `Option<std::tuple<int_fd, int_fd, int_fd>>`



3rdparty/stout/tests/os_tests.cpp
Lines 927-929 (original), 927-930 (patched)
<https://reviews.apache.org/r/60328/#comment255111>

    Would be clearer to say "`os::shell()` is explicitly disallowed on Windows."


- Joseph Wu


On June 21, 2017, 3:12 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60328/
> -----------------------------------------------------------
> 
> (Updated June 21, 2017, 3:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu,
Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-6817, MESOS-7371 and MESOS-7407
>     https://issues.apache.org/jira/browse/MESOS-6817
>     https://issues.apache.org/jira/browse/MESOS-7371
>     https://issues.apache.org/jira/browse/MESOS-7407
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This removes the use of unsupported CRT functions from the `os::`
> namespace, and reimplements them using `CreateProcess()`.
> 
> The CRT APIs behave unpredictably in the context of long paths, and are
> not necessary. Furthermore, it is not possible to use the Visual Studio
> Child Process Debugger for processes spawned by any API other than
> `CreateProcess()`.
> 
> Some unused functions were explicitly deleted to avoid future bugs.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/cmake/StoutConfigure.cmake 6b1d27fc53e49ac3378c17017c72ecfb2e3739ac

>   3rdparty/stout/include/stout/os/windows/shell.hpp b93f33771302ebbb1ce0c8515a3101a33f9956f5

>   3rdparty/stout/tests/os/process_tests.cpp 09f749528fa34935a7ac69921a6d7acc73af16e8

>   3rdparty/stout/tests/os_tests.cpp 7f785b07feaed28e272b4195362eb83842813e2b 
> 
> 
> Diff: https://reviews.apache.org/r/60328/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message