mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60324: Windows: Implemented `WSTRINGIFY()` to print exit codes.
Date Tue, 11 Jul 2017 00:14:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60324/#review180072
-----------------------------------------------------------


Ship it!





src/common/status_utils.hpp
Lines 35-37 (original), 36-38 (patched)
<https://reviews.apache.org/r/60324/#comment255078>

    Hm... Given non-standard exit codes, I don't see much reason to keep MESOS-5417 around
and un-resolved.  We basically can't do better than just stringifying the status.
    
    I'll update this comment and TODO.


- Joseph Wu


On June 21, 2017, 3:08 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60324/
> -----------------------------------------------------------
> 
> (Updated June 21, 2017, 3:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu,
Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-5417
>     https://issues.apache.org/jira/browse/MESOS-5417
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Implemented `WSTRINGIFY()` to print exit codes.
> 
> 
> Diffs
> -----
> 
>   src/common/status_utils.hpp 36df84d0112dd824e001df010a5f4ccbf2229006 
> 
> 
> Diff: https://reviews.apache.org/r/60324/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message