mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 59764: Ignore registration attempts by agents with misconfigured domain.
Date Tue, 11 Jul 2017 00:00:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59764/#review180143
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Lines 6090 (patched)
<https://reviews.apache.org/r/59764/#comment255160>

    s/; to/. To/ ? to be consistent with the above comment?


- Vinod Kone


On July 5, 2017, 10:32 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59764/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 10:32 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7612
>     https://issues.apache.org/jira/browse/MESOS-7612
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We expect the master's domain to be configured first, then the domain of
> the agents to be configured. Therefore, if an agent with configured
> domain attempts to register or re-register with a master that does not
> have a configured domain, the registration attempt should be ignored.
> This is important, because the master would have no way of determining
> whether the agent is "remote" or not, which might result in placing
> inappropriate workloads on it.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 56b170ed70722eba30d98f6e648b6a31580d6b56 
>   src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f 
> 
> 
> Diff: https://reviews.apache.org/r/59764/diff/4/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message