mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60314: Windows: Fixed `os::rmdir()` to support long paths.
Date Mon, 10 Jul 2017 23:58:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60314/#review179961
-----------------------------------------------------------


Ship it!





3rdparty/stout/include/stout/os/windows/rmdir.hpp
Lines 30 (patched)
<https://reviews.apache.org/r/60314/#comment254925>

    Technically not necessary as part of this change, but I see usage of a function defined
in the reparsepoint header in this header.  So I'll keep this here.


- Joseph Wu


On June 21, 2017, 3:03 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60314/
> -----------------------------------------------------------
> 
> (Updated June 21, 2017, 3:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu,
Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-6817, MESOS-7371 and MESOS-7407
>     https://issues.apache.org/jira/browse/MESOS-6817
>     https://issues.apache.org/jira/browse/MESOS-7371
>     https://issues.apache.org/jira/browse/MESOS-7407
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Fixed `os::rmdir()` to support long paths.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/rmdir.hpp 05eceea94d2be71173584c71570f5f2f95fab744

> 
> 
> Diff: https://reviews.apache.org/r/60314/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message