mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60299: Windows: Fixed `os::exists()` to support long paths.
Date Mon, 10 Jul 2017 23:43:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60299/#review179665
-----------------------------------------------------------


Ship it!




LGTM.  I'll tweak the below before committing.


3rdparty/stout/include/stout/os/windows/exists.hpp
Line 20 (original), 20 (patched)
<https://reviews.apache.org/r/60299/#comment254477>

    Since you aren't using the `get_file_attributes` helper in this file, you don't need this
header.


- Joseph Wu


On June 21, 2017, 2:57 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60299/
> -----------------------------------------------------------
> 
> (Updated June 21, 2017, 2:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu,
Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-6817, MESOS-7371 and MESOS-7407
>     https://issues.apache.org/jira/browse/MESOS-6817
>     https://issues.apache.org/jira/browse/MESOS-7371
>     https://issues.apache.org/jira/browse/MESOS-7407
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Fixed `os::exists()` to support long paths.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/exists.hpp 42b8a9d6cca7e13c8feac997f5d6de8cdcc007f4

> 
> 
> Diff: https://reviews.apache.org/r/60299/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message