mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60296: Windows: Added long path test.
Date Mon, 10 Jul 2017 23:41:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60296/#review179064
-----------------------------------------------------------


Ship it!




Hum, looks like this test shouldn't pass until after the patches for `os::mkdir`, `os::open`,
`os::exists`, `os::access`, and `os::realpath` are in.
Although since this chain will be going in all at once, the ordering is less important.

- Joseph Wu


On June 21, 2017, 2:55 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60296/
> -----------------------------------------------------------
> 
> (Updated June 21, 2017, 2:55 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu,
Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-6817, MESOS-7371 and MESOS-7407
>     https://issues.apache.org/jira/browse/MESOS-6817
>     https://issues.apache.org/jira/browse/MESOS-7371
>     https://issues.apache.org/jira/browse/MESOS-7407
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added long path test.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/os/filesystem_tests.cpp ee5a1a1f7e1aa4e2838a7df8b39266d5bdcb3db7

> 
> 
> Diff: https://reviews.apache.org/r/60296/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message