mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 60697: Added mesos.http module for abstracting out http requests in the new cli.
Date Mon, 10 Jul 2017 10:06:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60697/#review180020
-----------------------------------------------------------



Patch looks great!

Reviews applied: [60697]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 7, 2017, 1:28 a.m., Eric Chung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60697/
> -----------------------------------------------------------
> 
> (Updated July 7, 2017, 1:28 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Part of MESOS-7310, this patch adds the mesos.http module to the src/python/lib/mesos
> package. This module will encapsulate the details in making an http request, such as
> auth scheme, default headers, timeouts, and so on. Retries will be added in subsequent
diffs.
> 
> 
> Diffs
> -----
> 
>   src/python/lib/mesos/http.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60697/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eric Chung
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message