> On July 8, 2017, 1:19 a.m., Greg Mann wrote:
> > src/master/http.cpp
> > Line 380 (original), 380-381 (patched)
> > <https://reviews.apache.org/r/59525/diff/5/?file=1771257#file1771257line380>
> >
> > To avoid shadowing in constructors, we use leading underscores rather than trailing.
Or even better, use trailing underscores on your members.
> On July 8, 2017, 1:19 a.m., Greg Mann wrote:
> > src/master/http.cpp
> > Lines 2374-2380 (original), 2402-2410 (patched)
> > <https://reviews.apache.org/r/59525/diff/5/?file=1771257#file1771257line2412>
> >
> > For the used resources, a role can be present in both `resource.role()` and
in `resource.allocation_info().role()`. Should we also be filtering based on the allocated
role?
Good point - should we?
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59525/#review179926
-----------------------------------------------------------
On July 7, 2017, 3:05 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59525/
> -----------------------------------------------------------
>
> (Updated July 7, 2017, 3:05 p.m.)
>
>
> Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-7416
> https://issues.apache.org/jira/browse/MESOS-7416
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds support of the 'VIEW_ROLE' ACL to the results generated by the
> '/slaves' as well as the 'GET_AGENTS' API v1 call, '/states' and
> '/states-summary'.
>
> This means that calls to these endpoints and API call which uses
> reservations will only show the reserved resources the user making the
> requests is allowed to see based on the reservations roles.
>
>
> Diffs
> -----
>
> src/master/http.cpp 175a44ce7fb5be509453c25eaa9ec29f35adba3a
> src/master/master.hpp 95c2d0fab32d6b60f29a86037607ff009bd78717
> src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f
>
>
> Diff: https://reviews.apache.org/r/59525/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
|