mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 59525: Enabled filtering of reservations.
Date Sat, 08 Jul 2017 01:19:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59525/#review179926
-----------------------------------------------------------




src/master/http.cpp
Line 380 (original), 380-381 (patched)
<https://reviews.apache.org/r/59525/#comment254948>

    To avoid shadowing in constructors, we use leading underscores rather than trailing.



src/master/http.cpp
Line 2320 (original), 2330 (patched)
<https://reviews.apache.org/r/59525/#comment254858>

    Now that this is a Writer struct, perhaps it should be moved to the top of the file along
with the others?



src/master/http.cpp
Lines 2325-2327 (original), 2333-2336 (patched)
<https://reviews.apache.org/r/59525/#comment254956>

    Ditto here regarding leading underscores.



src/master/http.cpp
Lines 2374-2380 (original), 2402-2410 (patched)
<https://reviews.apache.org/r/59525/#comment254957>

    For the used resources, a role can be present in both `resource.role()` and in `resource.allocation_info().role()`.
Should we also be filtering based on the allocated role?



src/master/http.cpp
Lines 2384-2391 (original), 2414-2421 (patched)
<https://reviews.apache.org/r/59525/#comment254950>

    Why aren't we filtering this field as well?



src/master/http.cpp
Lines 3186-3189 (original), 3255-3258 (patched)
<https://reviews.apache.org/r/59525/#comment254958>

    Could you fix the indentation of this lambda? The body should be two spaces indented with
respect to the line with the opening curly brace `{`. Or is the indentation unmanageable if
we do that here?


- Greg Mann


On July 7, 2017, 3:05 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59525/
> -----------------------------------------------------------
> 
> (Updated July 7, 2017, 3:05 p.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-7416
>     https://issues.apache.org/jira/browse/MESOS-7416
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds support of the 'VIEW_ROLE' ACL to the results generated by the
> '/slaves' as well as the 'GET_AGENTS' API v1 call, '/states' and
> '/states-summary'.
> 
> This means that calls to these endpoints and API call which uses
> reservations will only show the reserved resources the user making the
> requests is allowed to see based on the reservations roles.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 175a44ce7fb5be509453c25eaa9ec29f35adba3a 
>   src/master/master.hpp 95c2d0fab32d6b60f29a86037607ff009bd78717 
>   src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f 
> 
> 
> Diff: https://reviews.apache.org/r/59525/diff/5/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message