mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 60720: Fixed initialization of `__address__` in the abscense of `--ip` flag.
Date Sat, 08 Jul 2017 00:02:18 GMT


> On July 7, 2017, 11:18 p.m., Jiang Yan Xu wrote:
> > Could you fill out the 'testing done' section? I know there will be a follow up
test patch but for this at least `make check` and manual verification?
> 
> Jiang Yan Xu wrote:
>     I committed it but could you respond to the comments afterwards and follow up on
them in another review (if needed)?

Thanks Yan !! Will follow it up with a patch.


> On July 7, 2017, 11:18 p.m., Jiang Yan Xu wrote:
> > 3rdparty/libprocess/src/process.cpp
> > Line 1135 (original), 1135 (patched)
> > <https://reviews.apache.org/r/60720/diff/1/?file=1771682#file1771682line1135>
> >
> >     You are (re)initalizing/resetting this `__address__` but not `__address6__`
(to None). Should they be consistent?
> >     
> >     Given it's initialized at definition and reset during `finailize` perhaps it
doesn't need to be done here?
> >     
> >     If it needs to be done, can it be moved down closer to where the modifications/reassignments
are done?

`__address6__` is optional hence we don't initialize it (in fact its initalized to `None()`)


> On July 7, 2017, 11:18 p.m., Jiang Yan Xu wrote:
> > 3rdparty/libprocess/src/process.cpp
> > Lines 1151-1157 (original), 1151-1158 (patched)
> > <https://reviews.apache.org/r/60720/diff/1/?file=1771682#file1771682line1151>
> >
> >     Why do you need to modify the current instance of `__address__` in the case
above but but have to create a new instance of `inet::Address` in the case below?
> >     
> >     Can they be made consistent?

yeah I can just set `__address__.ip = libprocess_flags->ip.get()`


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60720/#review179958
-----------------------------------------------------------


On July 7, 2017, 10:04 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60720/
> -----------------------------------------------------------
> 
> (Updated July 7, 2017, 10:04 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7769
>     https://issues.apache.org/jira/browse/MESOS-7769
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When we introduced the `__address6__ optional IPv6 storage into
> `libprocess` we also introduced a regression because of which the `port`
> doesn't get initialized to whatever is specified in the `--port` flag
> until the `--ip` flag is specified.
> 
> This change fixes the initialization of the `__address__` in the
> absence of the `--ip` flag.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 264298c16199ded4ccbf948f6893f4209c23aed0 
> 
> 
> Diff: https://reviews.apache.org/r/60720/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message