mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 60720: Fixed initialization of `__address__` in the abscense of `--ip` flag.
Date Fri, 07 Jul 2017 23:18:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60720/#review179958
-----------------------------------------------------------


Fix it, then Ship it!




Could you fill out the 'testing done' section? I know there will be a follow up test patch
but for this at least `make check` and manual verification?


3rdparty/libprocess/src/process.cpp
Line 1135 (original), 1135 (patched)
<https://reviews.apache.org/r/60720/#comment254915>

    You are (re)initalizing/resetting this `__address__` but not `__address6__` (to None).
Should they be consistent?
    
    Given it's initialized at definition and reset during `finailize` perhaps it doesn't need
to be done here?
    
    If it needs to be done, can it be moved down closer to where the modifications/reassignments
are done?



3rdparty/libprocess/src/process.cpp
Lines 1151-1157 (original), 1151-1158 (patched)
<https://reviews.apache.org/r/60720/#comment254929>

    Why do you need to modify the current instance of `__address__` in the case above but
but have to create a new instance of `inet::Address` in the case below?
    
    Can they be made consistent?



3rdparty/libprocess/src/process.cpp
Line 1191 (original), 1192 (patched)
<https://reviews.apache.org/r/60720/#comment254919>

    Should `advertise_ip` be treated the same way as `ip`? i.e., flag validation and choice
between reassignment and modification.


- Jiang Yan Xu


On July 7, 2017, 3:04 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60720/
> -----------------------------------------------------------
> 
> (Updated July 7, 2017, 3:04 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7769
>     https://issues.apache.org/jira/browse/MESOS-7769
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When we introduced the `__address6__ optional IPv6 storage into
> `libprocess` we also introduced a regression because of which the `port`
> doesn't get initialized to whatever is specified in the `--port` flag
> until the `--ip` flag is specified.
> 
> This change fixes the initialization of the `__address__` in the
> absence of the `--ip` flag.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 264298c16199ded4ccbf948f6893f4209c23aed0 
> 
> 
> Diff: https://reviews.apache.org/r/60720/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message