mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 60524: Stout: Made the `Duration` operators handle int overflows explicitly.
Date Fri, 07 Jul 2017 20:36:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60524/#review179932
-----------------------------------------------------------




3rdparty/stout/include/stout/duration.hpp
Line 35 (original), 35 (patched)
<https://reviews.apache.org/r/60524/#comment254872>

    Consider updating this to return an error in case of over/underflow, like `create()`.



3rdparty/stout/include/stout/duration.hpp
Lines 121 (patched)
<https://reviews.apache.org/r/60524/#comment254866>

    two slashes only



3rdparty/stout/include/stout/duration.hpp
Lines 136 (patched)
<https://reviews.apache.org/r/60524/#comment254867>

    two slashes only



3rdparty/stout/include/stout/duration.hpp
Lines 149-150 (patched)
<https://reviews.apache.org/r/60524/#comment254869>

    Investigate if this is easy to do now.



3rdparty/stout/include/stout/duration.hpp
Lines 152 (patched)
<https://reviews.apache.org/r/60524/#comment254868>

    End comments with a period, here and elsewhere.


- Greg Mann


On June 28, 2017, 11:23 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60524/
> -----------------------------------------------------------
> 
> (Updated June 28, 2017, 11:23 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Vinod
Kone.
> 
> 
> Bugs: MESOS-7661
>     https://issues.apache.org/jira/browse/MESOS-7661
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made the `Duration` arithmetic operators return `Duration::max()` if the
> operation would result in an integer overflow, and `Duration::min()` if
> it would result in an underflow.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/duration.hpp b0cd77b833f6fbf752b4db820fd43b87e1d1e476

>   3rdparty/stout/tests/duration_tests.cpp 59b08f14849a8db31f11fbd0b2e1248c99afd9dd 
> 
> 
> Diff: https://reviews.apache.org/r/60524/diff/1/
> 
> 
> Testing
> -------
> 
> Added new Stout tests and confirmed that the Mesos test suite still passes.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message