-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59763/#review179908
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On July 5, 2017, 10:32 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59763/
> -----------------------------------------------------------
>
> (Updated July 5, 2017, 10:32 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7611
> https://issues.apache.org/jira/browse/MESOS-7611
>
>
> Repository: mesos
>
>
> Description
> -------
>
> That is, if a standby master is configured to use region X but it learns
> that the current master has region Y, the standby master will abort with
> an error message. This enforces the requirement that all masters in a
> single Mesos cluster are configured to use the same region (they can be
> configured to use different zones in that region, however).
>
> To allow graceful upgrades, we only abort the standby master if both the
> standby master and the leading master have a configured domain; if
> either master has the unset (default) domain, the standby master does
> not abort.
>
> NOTE: It would be nice to have unit tests to validate this behavior, but
> the current unit test infrastructure does not support starting multiple
> masters (MESOS-2976).
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp d2a6591b65b95b4e37e6a87dd3b11377834daf85
> include/mesos/v1/mesos.hpp 2479b004f342ffcb05279e3b12b6de6949190a93
> src/master/master.cpp 56b170ed70722eba30d98f6e648b6a31580d6b56
>
>
> Diff: https://reviews.apache.org/r/59763/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
> Manual testing.
>
>
> Thanks,
>
> Neil Conway
>
>
|