mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 60693: Move permissions.hpp under posix
Date Fri, 07 Jul 2017 18:43:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60693/#review179901
-----------------------------------------------------------




src/common/protobuf_utils.cpp
Line 41 (original), 41 (patched)
<https://reviews.apache.org/r/60693/#comment254820>

    It's really weird that this file is cross platform, but we have posix only header includes.
    
    That means the permissions.hpp compiles on Windows previously?


- Jie Yu


On July 6, 2017, 10:44 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60693/
> -----------------------------------------------------------
> 
> (Updated July 6, 2017, 10:44 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Jie Yu.
> 
> 
> Bugs: MESOS-7764
>     https://issues.apache.org/jira/browse/MESOS-7764
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The way permissions are dealt with are not cross-compatible with Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/posix/os.hpp 8511dfd41 
>   src/common/http.cpp 2f7718cbc 
>   src/common/protobuf_utils.cpp 4e5ab02c9 
>   src/credentials/credentials.hpp c790793c7 
>   src/tests/containerizer/provisioner_backend_tests.cpp e3516fca0 
>   src/tests/fetcher_tests.cpp 99149baa1 
> 
> 
> Diff: https://reviews.apache.org/r/60693/diff/1/
> 
> 
> Testing
> -------
> 
> `mkdir build && cd build && cmake .. && make -j$(nproc) &&
make check -j$(nproc)`
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message