mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 59525: Enabled filtering of reservations.
Date Fri, 07 Jul 2017 15:05:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59525/
-----------------------------------------------------------

(Updated July 7, 2017, 5:05 p.m.)


Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.


Changes
-------

Rebased based on the changes of reservations.


Bugs: MESOS-7416
    https://issues.apache.org/jira/browse/MESOS-7416


Repository: mesos


Description
-------

Adds support of the 'VIEW_ROLE' ACL to the results generated by the
'/slaves' as well as the 'GET_AGENTS' API v1 call, '/states' and
'/states-summary'.

This means that calls to these endpoints and API call which uses
reservations will only show the reserved resources the user making the
requests is allowed to see based on the reservations roles.


Diffs (updated)
-----

  src/master/http.cpp 175a44ce7fb5be509453c25eaa9ec29f35adba3a 
  src/master/master.hpp 95c2d0fab32d6b60f29a86037607ff009bd78717 
  src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f 


Diff: https://reviews.apache.org/r/59525/diff/5/

Changes: https://reviews.apache.org/r/59525/diff/4-5/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message