mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood via Review Board <nore...@reviews.apache.org>
Subject Review Request 60693: Move permissions.hpp under posix
Date Thu, 06 Jul 2017 22:44:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60693/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer and Jie Yu.


Bugs: MESOS-7764
    https://issues.apache.org/jira/browse/MESOS-7764


Repository: mesos


Description
-------

The way permissions are dealt with are not cross-compatible with Windows.


Diffs
-----

  3rdparty/stout/include/stout/posix/os.hpp 8511dfd41 
  src/common/http.cpp 2f7718cbc 
  src/common/protobuf_utils.cpp 4e5ab02c9 
  src/credentials/credentials.hpp c790793c7 
  src/tests/containerizer/provisioner_backend_tests.cpp e3516fca0 
  src/tests/fetcher_tests.cpp 99149baa1 


Diff: https://reviews.apache.org/r/60693/diff/1/


Testing
-------

`mkdir build && cd build && cmake .. && make -j$(nproc) &&
make check -j$(nproc)`


Thanks,

Aaron Wood


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message