mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 60638: Changed semantics of allocator 'updateSlave' method.
Date Thu, 06 Jul 2017 16:35:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60638/
-----------------------------------------------------------

(Updated July 6, 2017, 6:35 p.m.)


Review request for mesos, Benjamin Mahler, Jie Yu, and Jan Schlicht.


Changes
-------

Changed semantics of `Allocator::updateSlave` instead of adding a semantically very close
`total` resources in addition to the existing `oversubscribed`.


Summary (updated)
-----------------

Changed semantics of allocator 'updateSlave' method.


Bugs: MESOS-7755
    https://issues.apache.org/jira/browse/MESOS-7755


Repository: mesos


Description (updated)
-------

We change the semantics of the 'updateSlave' method present in the
allocator interface. While previously the passed optional resource
argument was interpreted as the amount of (new) oversubscribed
resources, it now represents the new amount of total resources on the
given agent.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp bec9e0b8ef8d51ec22f9e8af69407ed5ecaa3e8f 
  src/master/allocator/mesos/allocator.hpp 2e780c92d5c5132abff32f1ce051c3bab2947f37 
  src/master/allocator/mesos/hierarchical.hpp 5c58cf401de9205e54300e0ce8433995cdf5cb7a 
  src/master/allocator/mesos/hierarchical.cpp eb01d8e6b1108866ebc049f9f4a46157823a3541 
  src/master/master.cpp 95e9691b3e3ef101e3e7ddc7a498d5c5bf2276e3 
  src/tests/hierarchical_allocator_tests.cpp 2a312a9af4bae679a0a4e7bf45a3c013513c5da2 


Diff: https://reviews.apache.org/r/60638/diff/2/

Changes: https://reviews.apache.org/r/60638/diff/1-2/


Testing
-------

Tested with https://reviews.apache.org/r/60639/.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message