mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 60280: Provide full path to the custom executor.
Date Thu, 06 Jul 2017 15:18:59 GMT


> On July 6, 2017, 2:59 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/launch.cpp
> > Lines 808 (patched)
> > <https://reviews.apache.org/r/60280/diff/7/?file=1769755#file1769755line808>
> >
> >     This line is longger than 80 chars:
> >     
> >     ```
> >     Jies-MacBook-Pro:mesos jie$ support/apply-review.sh -r 60280
> >     2017-07-05 19:39:04 URL:https://reviews.apache.org/r/60280/diff/raw/ [1397/1397]
-> "60280.patch" [1]
> >     Checking 1 C++ file
> >     src/slave/containerizer/mesos/launch.cpp:803:  Lines should be <= 80 characters
long  [whitespace/line_length] [2]
> >     src/slave/containerizer/mesos/launch.cpp:808:  Lines should be <= 80 characters
long  [whitespace/line_length] [2]
> >     Total errors found: 1
> >     No Python files to lint
> >     ```
> >     
> >     ALso, we need to test if working_directory is set or not.

Can't we just rely on `os::which` checking if the working_directory is set or not?


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60280/#review179745
-----------------------------------------------------------


On July 5, 2017, 9:03 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60280/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 9:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, James Peach, and Zhitao Li.
> 
> 
> Bugs: MESOS-7703
>     https://issues.apache.org/jira/browse/MESOS-7703
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a framework specifies use of its own executor and sets shell to false the executor
is never found. This provides the full path to the executor so that the `execvp` or `execvpe`
is successful.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launch.cpp 162ca1c2e 
> 
> 
> Diff: https://reviews.apache.org/r/60280/diff/7/
> 
> 
> Testing
> -------
> 
> `cd build && cmake .. -DCMAKE_BUILD_TYPE=Release && make -j4`
> Also spun up a master and agent, connected and sent a task using the UCR (both with and
without the use of an OCI image) via our own framework, and checked the sandbox to verify
that things went accordingly.
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message