mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 60675: Fixed compilation failure in port-mapping network isolator.
Date Thu, 06 Jul 2017 10:47:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60675/#review179768
-----------------------------------------------------------


Fix it, then Ship it!





src/linux/routing/filter/icmp.hpp
Line 48 (original), 48 (patched)
<https://reviews.apache.org/r/60675/#comment254604>

    Update the same comment in `src/linux/routing/filter/ip.hpp`?


- James Peach


On July 6, 2017, 5:03 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60675/
> -----------------------------------------------------------
> 
> (Updated July 6, 2017, 5:03 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-7762
>     https://issues.apache.org/jira/browse/MESOS-7762
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed compilation failure in port-mapping network isolator.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/filter/icmp.hpp bc0aed0f4fc7c48f06cece14aa9ec43d7fa36bc4 
>   src/linux/routing/route.hpp 01d4e7582b19a38bc39f8c394121fe0bed2c0d87 
>   src/linux/routing/route.cpp ceeaf8e557a88569e1f15b3ffc5f0746b66ea638 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 9d38289c7161d5e931053b587d115684ccc44c94

>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp cd008aaebcd42554a9a81d2b059269546f59c966

>   src/tests/containerizer/port_mapping_tests.cpp 16e015a8ac53a4aa5336b60c40228720b5f6910a

> 
> 
> Diff: https://reviews.apache.org/r/60675/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message